Fix babel transpiling issues #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixheidecke
added
Status:Needs-Review
💥 Acceptance tests webUISharingInternalGroups failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/4652/
|
💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/4652/
|
💥 Acceptance tests failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/4652/
|
💥 Acceptance tests failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/4652/
|
💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/4652/
|
DeepDiver1975
requested changes
Aug 12, 2019
apps/media-viewer/webpack.common.js
Outdated
| }] | ||
| rules: [ | ||
| { | ||
| test: /\.js$/, |
There was a problem hiding this comment.
why are here two rules for *.js?
felixheidecke
force-pushed
the
bugfix/ie11-fix-transpiling
branch
from
3c08fc3
to
6263a51
Compare
DeepDiver1975
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes ES6 transpiling issues in files and media viewer, that popped up in IE11.
Types of changes