Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redirect to access denied page #1939

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Fix redirect to access denied page #1939

merged 1 commit into from
Sep 9, 2019

Conversation

LukasHirt
Copy link
Contributor

Description

Use path instead of name in redirect.

Motivation and Context

The redirect wasn't working with name in push function.

How Has This Been Tested?

  • test environment: Manually
  1. Create fake error in authorisation
  2. Authorise
  3. Get redirected to access denied page

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer bug-solved labels Sep 9, 2019
@LukasHirt LukasHirt self-assigned this Sep 9, 2019
PVince81
PVince81 suggested changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better use existing route name instead of the path

src/store/user.js Outdated Show resolved Hide resolved
@LukasHirt LukasHirt force-pushed the bugfix/redirect-to-access-denied-page branch from 7b5ce22 to 0d82ad2 Compare September 9, 2019 14:20
PVince81
PVince81 approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5034/

20190909-143455-884.png
20190909-143516-675.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5037/

20190909-145118-123.png
20190909-145159-574.png
20190909-145222-749.png
20190909-145328-970.png
20190909-145329-241.png
20190909-145353-439.png
20190909-145353-691.png
20190909-145539-658.png
20190909-145604-721.png
20190909-145707-612.png
20190909-145732-611.png
20190909-145757-277.png
20190909-145821-939.png
20190909-145947-427.png
20190909-150026-109.png
20190909-150120-441.png
20190909-150151-794.png
20190909-150318-517.png
20190909-150318-763.png
20190909-150347-592.png
20190909-150347-835.png

@LukasHirt LukasHirt merged commit a64d262 into master Sep 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/redirect-to-access-denied-page branch September 9, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@Julian1998 Julian1998 Awaiting requested review from Julian1998

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukasHirt @ownclouders @PVince81