Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide comma before mdate if size is in pending state #2073

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Hide comma before mdate if size is in pending state #2073

merged 1 commit into from
Sep 26, 2019

Conversation

LukasHirt
Copy link
Contributor

How Has This Been Tested?

  • test environment: Manually
  1. Get item which returns no size
  2. See no comma before mdata

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer bug-solved labels Sep 25, 2019
@LukasHirt LukasHirt self-assigned this Sep 25, 2019
PVince81
PVince81 approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit b936e63 into master Sep 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/hide-comma-if-size-is-pending branch September 26, 2019 08:07
skshetry added a commit that referenced this pull request Sep 27, 2019
@skshetry
fixup! Merge pull request #2073 from owncloud/bugfix/hide-comma-if-si…
368acab 
…ze-is-pending
skshetry added a commit that referenced this pull request Sep 30, 2019
@skshetry
fixup! Merge pull request #2073 from owncloud/bugfix/hide-comma-if-si…
56f3113 
…ze-is-pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LukasHirt @PVince81