Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] Run phoenix tests on internet explorer #2082

Merged
merged 14 commits into from
Oct 11, 2019
Merged

[POC] Run phoenix tests on internet explorer #2082

merged 14 commits into from
Oct 11, 2019

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Sep 27, 2019

Description

add drone and nightwatch configuration for running acceptance tests in internet explorer using saucelabs.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@dpakach dpakach force-pushed the ie-test branch 5 times, most recently from 935e22a to 85f4d5e Compare September 30, 2019 06:41
@dpakach dpakach changed the title [POC] Run phoenix tests on internet explorer [WIP][POC] Run phoenix tests on internet explorer Sep 30, 2019
@dpakach dpakach force-pushed the ie-test branch 5 times, most recently from 400579a to d2d76f8 Compare October 1, 2019 06:05
@PVince81
Copy link
Contributor

PVince81 commented Oct 1, 2019

Regarding the issue with "finally", it seems to only happen when I have the markdown and other apps enabled. The files app works fine.

I noticed that we are not loading the "core-js" lib for those apps, maybe we need to add it there.
See here how it's loaded for the files app: https://github.com/owncloud/phoenix/blob/master/apps/files/src/default.js#L1

@LukasHirt
Copy link
Contributor

@dpakach @individual-it I tried pushing into this branch something that could maybe help with the finally promise error. Let me know if it helped you. If not feel free to simply drop the commit.

@individual-it
Copy link
Member

current status of the tests

29 scenarios (8 failed, 21 passed)
322 steps (8 failed, 51 skipped, 263 passed)
41m26.477s

skipped renaming and upload, fixed sharing, lets see whats next

@owncloud owncloud deleted a comment from ownclouders Oct 3, 2019
@owncloud owncloud deleted a comment from ownclouders Oct 3, 2019
@owncloud owncloud deleted a comment from ownclouders Oct 3, 2019
@individual-it
Copy link
Member

made rename and create folder input work

new status

32 scenarios (6 failed, 26 passed)
329 steps (6 failed, 48 skipped, 275 passed)
51m46.475s

@owncloud owncloud deleted a comment from ownclouders Oct 3, 2019
@individual-it
Copy link
Member

wow, that thing can really pass

32 scenarios (32 passed)
329 steps (329 passed)
70m47.679s
Done in 4256.80s.

now need to find out, why that single test fails on Chrome

@individual-it
Copy link
Member

the Chrome tests fail because of #2150
now waiting for #2151 to be merged

@owncloud owncloud deleted a comment from ownclouders Oct 4, 2019
@owncloud owncloud deleted a comment from ownclouders Oct 4, 2019
@owncloud owncloud deleted a comment from ownclouders Oct 4, 2019
@individual-it individual-it changed the title [WIP][POC] Run phoenix tests on internet explorer [POC] Run phoenix tests on internet explorer Oct 10, 2019
DeepDiver1975
DeepDiver1975 previously requested changes Oct 10, 2019
View reviewed changes
tests/drone/config.json Outdated
@@ -8,7 +8,7 @@
"authUrl": "http://owncloud/index.php/apps/oauth2/authorize"
},
"apps" : [
"files", "markdown-editor", "pdf-viewer", "media-viewer", "draw-io"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will have impact on the build command ... I'd love to keep this list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if the other apps are not tested (yet)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted that commit, lets see if it still passes

@owncloud owncloud deleted a comment from ownclouders Oct 10, 2019
individual-it and others added 13 commits October 10, 2019 15:43
@individual-it @LukasHirt
Add config for polyfills for apps for ie11
64fe047 
Co-authored-by: LukasHirt <lukashirt@mail.com>
@individual-it
make selenium port default 4444
d5f9afc
@individual-it
send END key an not RIGHT_ARROW multiple times to reach end of input
03c49f9
@individual-it
move navigateAndWaitTillLoaded logic to helper and reload one extra time
9f7cac7 
IE does not navigate correctly without the reload
@individual-it
send keys one by one for input fields that are problematic for IE
62ce322 
IE looses random keys when receiving the complete string
@individual-it
do not expect \n in collaborators data
27e5ed2
@individual-it
get webElementID by getting the first element of the object
101d425 
in IE the key is not "ELEMENT" but an other ID
@individual-it
do not use moveTo
a175307 
moveTo gives problems in IE and is not needed here
@individual-it
skip upload tests on IE
cc42157
@individual-it
declare the simple folder create test as smoke-test
0d3972b
@individual-it
increase cucumber-js timeout
16e015a
@individual-it
run smoke tests on IE11 on saucelabs
1ed712c
@phil-davis @individual-it
Add drone flexibility for IE11 and Edge
d613452
@phil-davis phil-davis self-requested a review October 10, 2019 10:36
@individual-it
Copy link
Member

to make sure IE tests still pass I've opened a temporary PR, running only them: #2208

@individual-it individual-it dismissed DeepDiver1975’s stale review October 11, 2019 09:18

solved, please review again

@DeepDiver1975 DeepDiver1975 merged commit 1f268c5 into master Oct 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the ie-test branch October 11, 2019 12:20
This was referenced Oct 11, 2019
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it left review comments

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@phil-davis phil-davis phil-davis approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

@skshetry skshetry Awaiting requested review from skshetry

Assignees

@individual-it individual-it

Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dpakach @PVince81 @LukasHirt @individual-it @DeepDiver1975 @phil-davis