Properly reset capabilities on logout #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When logging out, we also reset capabilities in the SET_CAPABILITIES mutation. To make sure that the cleared capabilities are persisted in localStorage, we must include the above mutation in the whitelist for vuex-persist.
💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/5379/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When logging out, we also reset capabilities in the SET_CAPABILITIES
mutation. To make sure that the cleared capabilities are persisted in
localStorage, we must include the above mutation in the whitelist for
vuex-persist.
See more detailed analysis here: #1882 (comment)
Related Issue
Indirectly related to #1882
Motivation and Context
Proper cleanup on log out and avoid side effects with public pages like public links.
How Has This Been Tested?
Login then log out. Then check local storage in the browser console, key "phoenixState" and in the JSON look at "user.capabilities" and "user.versions".
Before the fix, logging out would leave the values there.
After the fix, those arrays are properly cleared.
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: