Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more close options to file actions menu #2161

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Add more close options to file actions menu #2161

merged 1 commit into from
Oct 8, 2019

Conversation

LukasHirt
Copy link
Contributor

@LukasHirt LukasHirt commented Oct 4, 2019 •
edited

Description

Added close button and trigger close action on route change for file action menu.

Related Issue

How Has This Been Tested?

  • test environment: Manually
  1. Open file actions menu by clicking on file name
  2. Close the menu with close button
  3. Repeat step 1
  4. Navigate to some other route

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added the Status:Needs-Review Needs review from a maintainer label Oct 4, 2019
@LukasHirt LukasHirt self-assigned this Oct 4, 2019
@LukasHirt
Copy link
Contributor Author

I was now thinking how to implement tests for this and this seems to me as another great example o why we need the unit tests. It seems strange that we would test scenario "User opens actions and immediately closes them"

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5522/

20191004-125547-684.png
20191004-125615-211.png
20191004-125632-969.png
20191004-125650-033.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5522/

20191004-125604-415.png
20191004-125646-703.png
20191004-125704-110.png
20191004-125722-328.png

PVince81
PVince81 approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 4f25248 into master Oct 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/actions-menu branch October 8, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcus-herrmann marcus-herrmann marcus-herrmann left review comments

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] File download by click on filename opens a dialog that cannot be closed
5 participants
@LukasHirt @ownclouders @PVince81 @marcus-herrmann @DeepDiver1975