Feature/private link on external storage #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
reviewed
Oct 7, 2019
| } | ||
| if (this.highlightedFile.isMounted()) { | ||
| const file = encodeURIComponent(this.highlightedFile.name) | ||
| return window.location.href.split('?')[0] + `?scrollTo=${file}` |
There was a problem hiding this comment.
This will need to be edited to also enable navigating directly into folder in case it is one. Same for the "classic" private link with id. But that is a task for different PR.
There was a problem hiding this comment.
Maybe I missunderstand - but the url generated on the sidebar will bring any other user to the exactly same point. It would be very inconsistent if it would be different. Right?
LukasHirt
approved these changes
Oct 7, 2019
💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/5537/
|
💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/5541/
|
… after login. The route is stored in the session storage
DeepDiver1975
force-pushed
the
feature/privateLinkOnExternalStorage
branch
from
0c62157
to
7997bc2
Compare
delete-merged-branch
bot
deleted the
feature/privateLinkOnExternalStorage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR holds two changes:
In case of an mounted external storage the privateLink holdsing the fileid is useless. Each user will have a different fileid. In this case we use the current browser url as private link. Not really private anymore - but it works
In case any url to phoenix is used in an unauthenticated browser the route will be stored in the session storage of the browser and will be used as soon as the login process is finished, This replaces the private link specific storage.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: