Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors while deleting and renaming files #2177

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 8, 2019

Description

Delete and rename operations did not handle error conditions at all before this PR.
While it is UX-wise far from good - this is better then nothing.

The whole error handling flow as well as the user confirmation flow is under review at the moment.

As say: better then nothing

How Has This Been Tested?

  • Lock a file using webdav locks (cadaver or manual insert into database)
  • try to delete or rename
  • see error notification

Screenshots (if appropriate):

Screenshot from 2019-10-08 14-17-53
Screenshot from 2019-10-08 14-17-39

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Oct 8, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Oct 8, 2019
apps/files/src/store/actions.js Outdated Show resolved Hide resolved
@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/error-handling-delete-and-rename branch from 824ad56 to 033a62b Compare October 9, 2019 07:44
@DeepDiver1975 DeepDiver1975 merged commit 87710d0 into master Oct 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/error-handling-delete-and-rename branch October 9, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants