Files table virtual scroller #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
changed the title
LukasHirt
changed the title
10 tasks
LukasHirt
force-pushed
the
feature/virtual-scroller
branch
from
467ab39
to
444f50a
Compare
LukasHirt
commented
Oct 21, 2019
LukasHirt
force-pushed
the
feature/virtual-scroller
branch
from
444f50a
to
cab3761
Compare
|
as discussed, see if this brings us closed to fixed table headers |
|
also discussed: if we go with a generic file list component or list component as in #2077 (comment), we could integrate virtual scrolling there by default |
LukasHirt
force-pushed
the
feature/virtual-scroller
branch
from
cab3761
to
bdb7f32
Compare
|
Let's see what tests will say now. If they'll pass I think this PR will be ready for reviews. I still need to test it in IE11 though. |
💥 Acceptance tests Files failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7169/
|
LukasHirt
force-pushed
the
feature/virtual-scroller
branch
from
0b2ba18
to
0b14d84
Compare
💥 Acceptance tests Favorites failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7170/
|
💥 Acceptance tests SharingAcceptShares failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7170/
|
💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7170/
|
💥 Acceptance tests iPhone failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7170/
|
💥 Acceptance tests Files failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7170/
|
LukasHirt
force-pushed
the
feature/virtual-scroller
branch
from
0b14d84
to
f8be76b
Compare
💥 Acceptance tests SharingExternal failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7202/
|
💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/7202/
|
LukasHirt
force-pushed
the
feature/virtual-scroller
branch
5 times, most recently
from
2fe4748
to
729ee6c
Compare
|
conflict 🙈 |
skshetry
reviewed
Dec 17, 2019
Fixed sizes of columns Made responsive Adjusted layout Adjusted shared with list Bring back id for the list Moved virtual scroller into files app dependencies and added polyfill Make table header fixed Use only class selector for file row Added border and selected background colour Scroll files list Fixed file row selector Scroll with interval Moved findFile into custom commands and added wait for filesListContainer Fixed wrong name in private link feature Fixed wrong item type Moved row actions into own component and moved after files list Made functions async and escape double quotes Count files via counters in footer and fixed scrollToTop function Check if the item is actually visible and not only rendered and await click on row for private link Fixed trashbin delete tests Finishing touches for scroll functions and adjusted sharing functions to await scrolling Adjusted resharing tests Adjusted sharing and distance of scrolling Add position of header to get properly visible items Re-enable correct step in shared-with pages tests Bring waitForFileVisible into versions test Fixed mobile view Adjusted order of scroll for opening of sidebar and wait for file in shared with pages Use shareId as default id and get rid of two TODOs Remove unneccesary logs Check if list container is visible in scrollToTop, reorder calls for different scrolling and reuse filename attribute Added isVisible data state Adjusted selector for trashbin Changed selector for actions dropdown Escape double quotes Adjusted dependencies Adjusted filter selectors and label after ods update Fixed order of parameters Create replaceChar function
LukasHirt
force-pushed
the
feature/virtual-scroller
branch
from
729ee6c
to
facf93e
Compare
I'm separating pieces of code with new lines to make it more readable. |
|
@individual-it Changes implemented. |
|
Opened an issue for virtual scroll in trashbin - #2723 |
individual-it
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement virtual scroller into FileList component and adjust layout in affected lists.
Related Issue
Motivation and Context
Smooth experience when rendering loaded items.
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: