Feature/publish docker on tag #2485
Conversation
.drone.yml
Outdated
| @@ -4963,6 +4963,7 @@ steps: | |||
| image: toolhippie/docker:latest | |||
| commands: | |||
| - docker build -t owncloud/phoenix:${DRONE_COMMIT_SHA}-${DRONE_BUILD_NUMBER} . | |||
| - docker push owncloud/phoenix:${DRONE_COMMIT_SHA}-${DRONE_BUILD_NUMBER} | |||
There was a problem hiding this comment.
It should not be published with this tag, please define a proper tag, :latest could be built from master branch, a git tag should be autoi tagged, e.g. v1.1.0 gets tagged as :1, :1.1 and :1.1.0
There was a problem hiding this comment.
having proper automated releases on tag is what we need to do . yes
- pushing a tag
- build docker image and public
- build appstore tarzg and publish as github release (marketplace upload can happen manually)
| @@ -35,7 +35,7 @@ help: | |||
|
|
|||
| .PHONY: dist | |||
| dist: ## Build distribution | |||
| dist: distdir javascript oc-app distconf sign package | |||
| dist: distdir javascript oc-app distconf sign package docker-image | |||
There was a problem hiding this comment.
Why should that be part of the release makefile?
There was a problem hiding this comment.
I thought when doing a release having a docker image being spit out is reasonable ....
... this all needs more automation and then the release makefile can die ...
DeepDiver1975
force-pushed
the
feature/publish-docker-on-tag
branch
from
ef1ed89
to
8978e1c
Compare
| @@ -566,7 +566,8 @@ def buildDockerImage(): | |||
| 'DOCKER_HOST': 'tcp://docker:2375' | |||
| }, | |||
| 'commands': [ | |||
| 'docker build -t owncloud/phoenix:${DRONE_COMMIT_SHA}-${DRONE_BUILD_NUMBER} .' | |||
| 'docker build -t owncloud/phoenix:${DRONE_COMMIT_SHA}-${DRONE_BUILD_NUMBER} .', | |||
| 'docker push owncloud/phoenix:latest' | |||
There was a problem hiding this comment.
You need to add docker tag owncloud/phoenix:${DRONE_COMMIT_SHA}-${DRONE_BUILD_NUMBER} owncloud/phoenix:latest
DeepDiver1975
force-pushed
the
feature/publish-docker-on-tag
branch
from
8978e1c
to
297f5da
Compare
💥 Acceptance tests SharingInternalUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6532/
|
Description
Build a docker image for phoenix using build artifacts from drone and push the image to docker hub
Motivation and Context
Provide an image for phoenix
Types of changes
Checklist:
Open tasks: