Moved private link icon to "links" section #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
expecting some acceptance test failures to happen as the element has moved |
💥 Acceptance tests PrivateLinks failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6559/
|
💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6559/
|
💥 Acceptance tests iPhone failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6559/
|
💥 Acceptance tests Files failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6559/
|
|
@Julian1998 please adjust the tests |
Julian1998
force-pushed
the
feature/private-link-in-links-section
branch
from
98da625
to
f0f555f
Compare
💥 Acceptance tests PrivateLinks failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6764/
|
Julian1998
force-pushed
the
feature/private-link-in-links-section
branch
from
f0f555f
to
a72e1d0
Compare
💥 Acceptance tests PrivateLinks failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6765/
|
Julian1998
force-pushed
the
feature/private-link-in-links-section
branch
from
a72e1d0
to
8bffa78
Compare
💥 Acceptance tests Files failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6767/
|
💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6767/
|
… the links section
Julian1998
force-pushed
the
feature/private-link-in-links-section
branch
from
8bffa78
to
207b36a
Compare
|
@PVince81 Tests passed. Please review again. |
delete-merged-branch
bot
deleted the
feature/private-link-in-links-section
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed private links icon next to breadcrumb as well as the file destails and added it instead in… the links section
Description
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: