Don't re-filter autocomplete collaborators results for remote user #2569
Conversation
💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6801/
|
|
Seems there's more to it... Tests are expecting the filtering to also happen on display names. However as far as I remember the API doesn't always do this, depending on the setup. |
It's already done on server side
PVince81
changed the title
PVince81
force-pushed
the
fix-remote-user-autocomplete
branch
from
e3ab4f6
to
bc25869
Compare
|
I've adjusted the PR to only disable client side filtering for remote users, with the goal to unblock #2509 for now. We should still look into the general autocomplete filter thing. |
💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6804/
|
|
I've raised owncloud/core#36478 for the server side bug |
When testing users and groups we are not expecting remote users to appear. To make it work, we disable outgoing federated shares.
|
To fix the failing tests I had to disable federation because when testing the autocomplete for users containing an "@" character, there would be two results instead of one because of federation. |
💥 Acceptance tests Files failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6811/
|
|
WebUIFiles failed for some reason I have restared drone. |
💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6819/
|
|
trashbin also is a random fail. passes locally |
Description
The autocomplete for adding collaborators was filtering results that
were already filtered on the server side.
This makes the filterRecipients function return true as no filtering is
necessary.
Related Issue
Fixes #2509
Motivation and Context
How Has This Been Tested?
Manual test with "user1", "user11" and "user2".
Typing "user1" properly filters out "user2" as it's done on the server already.
Also tested "user@x" to make sure a federated share appears in the list as expected in #2509
Expecting that all autocomplete tests in CI will still pass.
Screenshots (if appropriate):
Types of changes
Checklist: