Added collaborator entries for owner and resharer #2915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
force-pushed
the
share-indirect-info
branch
from
d478c2c
to
d255f52
Compare
PVince81
force-pushed
the
share-indirect-info
branch
from
f46476e
to
6e6ed78
Compare
11 tasks
PVince81
changed the title
PVince81
force-pushed
the
share-indirect-info
branch
from
6e6ed78
to
eb4a285
Compare
|
There's one relevant test failure: tests/acceptance/features/webUIResharing/reshareUsers.feature:144 This is because a test expects no entries in the collaborators list but we now show the owner and resharer. Not sure why the test explicitly expects no collaborators. |
- Added incomingShares in state, requested whenever the collaborators panel is opened, and used to retrieve the owner and resharer information. - Share file owner and resharers are now displayed on top of the collaborators list for shares from the currently selected resource - Added skipped tests for the next steps of related features.
PVince81
force-pushed
the
share-indirect-info
branch
from
eb4a285
to
fc7a9ff
Compare
kulmann
approved these changes
Jan 27, 2020
This was referenced Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added share owner and resharer display for direct shares
panel is opened, and used to retrieve the owner and resharer
information.
collaborators list for shares from the currently selected resource
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: