Fix avatar spinner size #2927
Merged
Fix avatar spinner size #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2020
PVince81
force-pushed
the
fix-avatar-loading-duplicate-code
branch
from
6584cbf
to
5a1fd3f
Compare
kulmann
requested changes
Jan 28, 2020
There was a problem hiding this comment.
I don't like the new loading delay behaviour. When an Avatar get's rendered, it shows nothing but the loading spinner and after 5 seconds (timeout in Avatar component) the placeholder with the colored background and one capitalized letter in the center gets displayed. The impression is that the UI is not very responsive/fast. Would be better, to show the placeholder from the start and - without a loading spinner - replace it with the avatar image as soon as it's loaded. In my opinion this doesn't need a visual loading state.
|
The approach to have and use only one, globally available, avatar component is both good and useful. 🚀 |
PVince81
commented
Jan 29, 2020
9 tasks
PVince81
force-pushed
the
fix-avatar-loading-duplicate-code
branch
from
5a1fd3f
to
967b1da
Compare
LukasHirt
requested changes
Jan 29, 2020
| <oc-icon v-if="item.value.shareType === 1" class="uk-margin-small-right" name="group" size="large" /> | ||
| <oc-icon v-else class="uk-margin-small-right" name="person" size="large" /> | ||
| </template> | ||
| <oc-icon v-if="item.value.shareType === shareTypes.group" class="uk-margin-small-right" name="group" size="large" /> |
| <div v-else key="collaborator-avatar-placeholder"> | ||
| <oc-icon v-if="collaborator.info.share_type === '1'" class="uk-margin-small-right" name="group" size="large" /> | ||
| <oc-icon v-if="$_shareType === shareTypes.group" class="uk-margin-small-right" name="group" size="large" /> |
src/components/Avatar.vue
Outdated
| @@ -1,12 +1,15 @@ | |||
| <template> | |||
| <component :is="type" v-if="enabled"> | |||
| <oc-avatar :width="width" :loading="loading" :src="avatarSource" :userName="userName" /> | |||
| <oc-spinner v-if="loading" size="small" key="collaborator-avatar-spinner" :aria-label="$gettext('Loading')" | |||
PVince81
force-pushed
the
fix-avatar-loading-duplicate-code
branch
from
967b1da
to
690fb30
Compare
|
@LukasHirt I've added the requested keys, please recheck |
|
and I forgot the changelog entry as this is a bugfix |
Refactored avatar component logic to be located only in Phoenix core. Moved spinner into the avatar component. Adjusted spinner size to match the one of the avatar to avoid layout shifting.
PVince81
force-pushed
the
fix-avatar-loading-duplicate-code
branch
from
690fb30
to
5df30e4
Compare
LukasHirt
approved these changes
Jan 29, 2020
delete-merged-branch
bot
deleted the
fix-avatar-loading-duplicate-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored avatar component logic to be located only in Phoenix core.
Moved spinner into the avatar component.
Adjusted spinner size to match the one of the avatar to avoid layout shifting
Related Issue
Fix #2921
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: