We shall only call the sso end session endpoint in case we still have… #2961
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
force-pushed
the
bugfix/logout-without-id-token
branch
from
2f4a342
to
1012bba
Compare
|
I guess the test scenarios need to be adjusted .... |
|
The problem with tests is that logout leads us to "Access denied" page. Not sure if this is happening also in a setup with oidc provider or only with oauth2. |
|
The access denied page is appearing because of this line https://github.com/owncloud/phoenix/blob/f4eeac80a042b1d6ea4f72f004627e7631bc9476/src/store/user.js#L110 Would it be fine using here "Login" page instead or removing completely @DeepDiver1975 ? Can the user be unloaded because of some error? Or is it only when doing a logout? I guess also expiration? But even then I'd still expect to see login screen instead as a user. |
As a bonus you would come back to the route where you were before the logout (also in case of expiration), right? As of now you come back to the access denied route when you re-login after expiration. |
in the very first implementation we always redirected to the login screen - this was changed upon customer request. I find it rather complicated to differentiate when to display which page .... 🙈 |
DeepDiver1975
force-pushed
the
bugfix/logout-without-id-token
branch
from
1012bba
to
0765416
Compare
DeepDiver1975
force-pushed
the
bugfix/logout-without-id-token
branch
from
0765416
to
e5ea55c
Compare
added |
|
Hmm, looking at https://drone.owncloud.com/owncloud/phoenix/9041 the ocis tests seems to perform better than here. Maybe it is after all related somehow to this PR? |
seems to be - who has enough understanding on having a look? I lost track with ocis these days 🙈 |
@dpakach Would you have time to take a look at the ocis tests here? |
@LukasHirt I will try to run them locally and see what's going on |
|
All tests are failing on login so seems like something has changed in login flow |
… the id_token. In some sceanrios the id_token is no longer known (expiry)
dpakach
force-pushed
the
bugfix/logout-without-id-token
branch
from
e5ea55c
to
90313f2
Compare
|
Sorry, l am unable to reproduce this locally. I just rebased just to see what happens. |
The changes are actually in the opposite - logout.
It's green now, I'll try to run them one more time and if they'll still be green I'll merge it . Just to be sure 😉 Thanks a lot for taking a look! |
… the id_token. In some sceanrios the id_token is no longer known (expiry)
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: