Display current user in collaborators list #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
force-pushed
the
feature/current-user-in-collaborators
branch
from
dd3a780
to
ca8523f
Compare
LukasHirt
added
Status:Needs-Review
kulmann
reviewed
Feb 18, 2020
tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature
Outdated
Show resolved
Hide resolved
LukasHirt
force-pushed
the
feature/current-user-in-collaborators
branch
from
ca8523f
to
2f9c152
Compare
|
Right, now need to explain to all the sharing scenarios that it's not wrong that there is one extra item in the list 🤦♂ |
LukasHirt
added
Status:In-Progress
and removed
Status:Needs-Review
LukasHirt
force-pushed
the
feature/current-user-in-collaborators
branch
2 times, most recently
from
c78f71f
to
ded609c
Compare
LukasHirt
commented
Feb 19, 2020
| @@ -47,8 +47,7 @@ Feature: Sharing files with internal groups with permissions | |||
| | file_target | /lorem (2).txt | | |||
| | item_type | file | | |||
| | permissions | <actual-permissions> | | |||
| But user "User One" should not be listed in the collaborators list on the webUI | |||
There was a problem hiding this comment.
Removed because this step is no longer supposed to be true
| @@ -48,8 +48,7 @@ Feature: Sharing folders with internal groups with role as advanced permissions | |||
| | file_target | /simple-folder (2) | | |||
| | item_type | folder | | |||
| | permissions | <actual-permissions> | | |||
| But user "User One" should not be listed in the collaborators list on the webUI | |||
There was a problem hiding this comment.
Removed because this step is no longer supposed to be true
| @@ -48,8 +48,7 @@ Feature: Sharing folders with internal groups with different roles and permissio | |||
| | file_target | /simple-folder (2) | | |||
| | item_type | folder | | |||
| | permissions | <actual-permissions> | | |||
| But user "User One" should not be listed in the collaborators list on the webUI | |||
There was a problem hiding this comment.
Removed because this step is no longer supposed to be true
LukasHirt
added
Status:Needs-Review
LukasHirt
force-pushed
the
feature/current-user-in-collaborators
branch
from
ded609c
to
711e1bc
Compare
PVince81
reviewed
Feb 20, 2020
| @@ -563,3 +563,22 @@ Feature: Sharing files and folders with internal users | |||
| And the user opens the share dialog for folder "simple-folder" using the webUI | |||
| Then user "User Two" should be listed without additional info in the collaborators list on the webUI | |||
|
|
|||
| Scenario: collaborators list contains the current user when he is an owner | |||
There was a problem hiding this comment.
please always use the singular they: https://en.wikipedia.org/wiki/Singular_they
There was a problem hiding this comment.
Adjusted all the scenarios titles. Pls re-check if I got it right 😉
PVince81
reviewed
Feb 20, 2020
LukasHirt
force-pushed
the
feature/current-user-in-collaborators
branch
from
711e1bc
to
9556412
Compare
|
@PVince81 Addressed comments. Pls take a look one more time 🙂 |
delete-merged-branch
bot
deleted the
feature/current-user-in-collaborators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: