Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show token string if link name is empty in FileLinkSidebar #3297

Merged
merged 2 commits into from
Apr 24, 2020

Conversation

karakayasemi
Copy link
Contributor

Description

owncloud-js-client was parsing empty link name xml attribute as empty object. Empty object was changed with an empty string in store action.

Also, now FileLinkSidebar shows token string as name for the link shares without a name.

Related Issue

How Has This Been Tested?

  • Tested with issue steps.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@karakayasemi karakayasemi self-assigned this Apr 5, 2020
@update-docs
Copy link

update-docs bot commented Apr 5, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@karakayasemi karakayasemi force-pushed the empty-name-share branch 4 times, most recently from 8bdc64e to bfa20fb Compare April 11, 2020 21:56
@karakayasemi karakayasemi marked this pull request as ready for review April 12, 2020 06:10
@karakayasemi karakayasemi added the Status:Needs-Review Needs review from a maintainer label Apr 12, 2020
Copy link
Contributor

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Add just changelog pls

@individual-it
Copy link
Member

Would be good to have tests that check that the name of a unnamed link is really something that looks like the token. Something like

When user "user1" has created a public link with following settings
    | path        | simple-folder         |
Then a public link with the token as name should be listed for resource "simple-folder" on the webUI

please ping me if you need help with it

@karakayasemi karakayasemi force-pushed the empty-name-share branch 2 times, most recently from b26bf5b to 0c7a017 Compare April 15, 2020 09:00
@karakayasemi karakayasemi force-pushed the empty-name-share branch 2 times, most recently from d5a313d to 0931ad3 Compare April 16, 2020 07:19
@karakayasemi karakayasemi force-pushed the empty-name-share branch 2 times, most recently from 7184a07 to 3851d22 Compare April 23, 2020 15:28
@karakayasemi
Copy link
Contributor Author

@individual-it I have added both a new scenario similar to your suggestion and, a changelog entry. Please review them, thanks.

Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look good

@PVince81
Copy link
Contributor

@individual-it did you mistakenly click "request changes" instead of "approve" ?

@PVince81 PVince81 merged commit c76d4d7 into master Apr 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the empty-name-share branch April 24, 2020 08:55
@micbar micbar mentioned this pull request Apr 28, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

public link without name is not shown correctly
4 participants