Remove obsolete (and duplicate) error alert #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
force-pushed
the
fix-dialog-prompt
branch
from
1ef2bf2
to
05de016
Compare
LukasHirt
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Somehow the old
oc-alertsnuck in in the dialog prompt. When squashing the recent PR which added the new error message inoc-text-inputI dropped a commit - I suppose that removing the oldoc-alertwas part of that commit and I've probably missed that... This PR fixes the dialog prompt by removing it again.Motivation and Context
Dialog prompt shows the error message twice right now. Once within the oc-text-input component and once as an alert below. Obviously the alert has to be removed.
How Has This Been Tested?
Locally in Chrome and Firefox.
Screenshots (if appropriate):
Types of changes
Checklist: