Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin easygettext@2.9.0 - current 2.10.0 cannot extract string from pl… #3346

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Pin easygettext@2.9.0 - current 2.10.0 cannot extract string from pl… #3346

merged 1 commit into from
Apr 17, 2020

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Apr 17, 2020 •
edited

…ain js files

Description

easygettext@2.10.0 is broken - pinning 2.9.0

Related Issue

Polyconseil/easygettext#81

How Has This Been Tested?

  • ✋
  • make l10n-read
  • seach for *.js in template.pot

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 self-assigned this Apr 17, 2020
@update-docs
Copy link

update-docs bot commented Apr 17, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/pin-easygettext-to-fix-js-extraction branch from fca2c6b to 66ba303 Compare April 17, 2020 11:46
@DeepDiver1975 DeepDiver1975 changed the title Ping easygettext@2.9.0 - current 2.10.0 cannot extract string from pl… Pin easygettext@2.9.0 - current 2.10.0 cannot extract string from pl… Apr 17, 2020
@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/pin-easygettext-to-fix-js-extraction branch from 66ba303 to afe57c1 Compare April 17, 2020 12:24
@DeepDiver1975 DeepDiver1975 merged commit 61064be into master Apr 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/pin-easygettext-to-fix-js-extraction branch April 17, 2020 13:28
@micbar micbar mentioned this pull request Apr 28, 2020
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

Assignees

@DeepDiver1975 DeepDiver1975

Labels
Status:Needs-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DeepDiver1975 @LukasHirt