Send mtime with uploads #3377
Merged
Send mtime with uploads #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Note: with TUS upload (chunked upload) we already send the mtime. |
Closed
PVince81
force-pushed
the
upload-send-mtime
branch
from
bb6817f
to
57f92db
Compare
LukasHirt
approved these changes
Apr 24, 2020
kulmann
reviewed
Apr 24, 2020
💥 Acceptance tests webUIOCIS failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/9531/
|
💥 Acceptance tests webUIOCIS failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/9548/
|
|
Strange. Uploading works for me with manual upload also with OCIS. Next up to try:
|
PVince81
force-pushed
the
upload-send-mtime
branch
from
57f92db
to
944971e
Compare
|
fixed the minor comment and rebased. |
💥 Acceptance tests webUIOCIS failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/9653/
|
Aligns with the behavior of OC 10 which itself was aligned with the behavior of the desktop client.
PVince81
force-pushed
the
upload-send-mtime
branch
from
944971e
to
2cb8266
Compare
|
finally tests passed. I guess the side effects might have been resolved with recent work on stabilizing upload tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aligns with the behavior of OC 10 which itself was aligned with the
behavior of the desktop client.
Related Issue
Fixes #2969
Motivation and Context
How Has This Been Tested?
See #2969
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: