Move navItems into a store module #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NavItems now live in a `navigation` store module in phoenix core. They are internally separated into static and dynamic navItems. Static is for the navItems loaded from an extension config. Dynamic is for dynamically loaded navItems (most likely from loaded data).
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
1 task
LukasHirt
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NavItems now live in a
navigationstore module in phoenix core. They are internally separated into static and dynamic navItems. Static is for the navItems loaded from an extension config. Dynamic is for dynamically loaded navItems (most likely from loaded data). A known limitation of this implementation is, that only statically loaded navItems (the ones coming from appInfo) lead to the extension appearing in the app switcher. As the app switcher is likely to change in the near future, we can touch this separately.Related Issue
Motivation and Context
We need dynamically loaded navItems that are based on loaded data, not on configuration.
How Has This Been Tested?
For now with Chrome and Firefox locally, with code in settings ui depending on this change (injecting navItems through the store). Statically loaded navItems are now loaded differently (into the store) but the functionality stays the same. Acceptance tests are covering that.
Types of changes
Checklist: