Remove head request

[kulmann]

Same as #3797, but without the HEAD request. If a download fails, it just fails. No need to determine beforehand if it could fail.

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[kulmann]

@IljaN check out this PR and run yarn build in phoenix. Restarting ocis should not be required. If the download works in the browser, everything is fine.

[IljaN]

Works for me:

[kulmann]

@IljaN the actual download is not visible in the network tab - only as file in your download list. did that appear?

[IljaN]

Yeah sorry I see now that the image is cropped wrongly... Nothing more visible in the Network tab. But browser Download-File picker appeared and I could download file.

[kulmann]

successfully downloaded a 6GB random data file (on localhost) with this PR.

[kulmann]

failure handling needs to be fixed/decided before we can merge this.

With the browser api this is what happens on failures:

So there is no error dialog triggered in phoenix. Which could be ok. Need to decide it.

[kulmann]

Closing this, since we decided to keep (and fix) the HEAD request for now. Otherwise we'd need to change all download related tests.