Media viewer public context #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mediaSource` plugin doesn't support signed urls at the moment, because it would slow down the whole file list init the way signed urls are implement at the moment. Reason: signed urls retrieve the signing key on every request. As a result ALL requests for e.g. thumbnails in the files list will make two requests instead of one. As long as that is not fixed, we will continue to fetch previews and images in general (also in the mediaviewer) as blobs. Only other file types (e.g. videos) are fetched with signed urls.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
LukasHirt
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes loading videos in a public context (public link) within the mediaviewer.
Related Issue
Motivation and Context
Bugfix
Types of changes
Checklist: