Make file previews properly fit #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: |
Fix file preview to prevent overflowing vertically and also added CSS property to make sure the ratio is preserved.
PVince81
force-pushed
the
fix-preview-size
branch
from
9d1d731
to
8d858f7
Compare
LukasHirt
approved these changes
Sep 15, 2020
|
Yeah, intelligent cropping could be cool. Please note that here this problem also happens with OC 10, so it's independent from the backend so fits well as a generic fix. |
|
fun stuff... job restarted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix file preview to prevent overflowing vertically and also added CSS
property to make sure the ratio is preserved.
Related Issue
Fixes owncloud/product#232
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: