Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide modals on logout #4472

Merged
merged 3 commits into from
Dec 12, 2020
Merged

hide modals on logout #4472

merged 3 commits into from
Dec 12, 2020

Conversation

fschade
Copy link
Collaborator

@fschade fschade commented Dec 11, 2020

LukasHirt
LukasHirt approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

kulmann
kulmann reviewed Dec 11, 2020
View reviewed changes
src/store/user.js Outdated Show resolved Hide resolved
kulmann
kulmann approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@phil-davis
Copy link
Contributor

Rebased - that might make CI happy.

@phil-davis phil-davis merged commit 22a93bc into master Dec 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the hide-modals branch December 12, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@LukasHirt LukasHirt LukasHirt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure that phoenix hides modals when user is logged out
4 participants
@fschade @phil-davis @kulmann @LukasHirt