Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring three-dot/contextmenu in filestable rows to web #5551

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Bring three-dot/contextmenu in filestable rows to web #5551

merged 3 commits into from
Jul 26, 2021

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Jul 20, 2021 •
edited

Description

See changelog item

Related Issue

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

Sidenote: I borrowed quite some code from #5557, perhaps we dry things up down the road!

@pascalwengerter pascalwengerter changed the title Sketch contextmenu usage in web Bring three-dot/contextmenu in filestable rows to web Jul 22, 2021
@pascalwengerter pascalwengerter force-pushed the contextmenu branch 7 times, most recently from 98f49e2 to 39dd774 Compare July 25, 2021 14:21
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.2% 72.2% Coverage
2.8% 2.8% Duplication

fschade
fschade approved these changes Jul 26, 2021
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

the only thing that looks a bit fishy to me is that the actions are handled as mixins.
This has nothing todo with this pr and can be handled in a later pr

@fschade fschade merged commit f664b8e into master Jul 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the contextmenu branch July 26, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open context menu on rightclick Open context menu from 3-dots
2 participants
@pascalwengerter @fschade