Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Restructure context menu items #5576

Merged
merged 10 commits into from
Jul 30, 2021
Merged

[full-ci] Restructure context menu items #5576

merged 10 commits into from
Jul 30, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 28, 2021 •
edited

Description

This PR restructures the context menu to not just list the actions from the right sidebar but instead to bring the structure that was proposed in #5160

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Screenshot 2021-07-28 at 23 29 33

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 28, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17741/49/1
The following scenarios passed on retry:

  • webUISharingAcceptShares/acceptShares.feature:109

@pascalwengerter pascalwengerter mentioned this pull request Jul 29, 2021
Closed
@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait1 https://drone.owncloud.com/owncloud/web/17780/41/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@LukasHirt LukasHirt marked this pull request as ready for review July 29, 2021 19:35
@LukasHirt LukasHirt changed the title Add existing named actions into context menu [full-ci] Add existing named actions into context menu Jul 29, 2021
@kulmann kulmann changed the title [full-ci] Add existing named actions into context menu [full-ci] Restructure context menu items Jul 29, 2021
@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/17799/39/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

74.2% 74.2% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/17816/27/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/17816/39/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

@kulmann kulmann merged commit 4d73892 into master Jul 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the context-menu-items branch July 30, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@fschade fschade Awaiting requested review from fschade

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interaction via context menu
3 participants
@kulmann @ownclouders @LukasHirt