Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup (dev)dependencies in root & app packages #5898

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Cleanup (dev)dependencies in root & app packages #5898

merged 3 commits into from
Oct 13, 2021

Conversation

pascalwengerter
Copy link
Contributor

Description

As discussed, this is just a starting point though

@kulmann
Copy link
Member

kulmann commented Oct 12, 2021

Linter is not happy anymore. 😢

@pascalwengerter
Copy link
Contributor Author

Linter is not happy anymore. cry

Seems like adding the direct dependency to prettier somehow makes it ignore the .prettierrc.json, I'll rollback the last (unnecessarily huge) commit and look into it

@kulmann
Copy link
Member

kulmann commented Oct 12, 2021

Linter is not happy anymore. cry

Seems like adding the direct dependency to prettier somehow makes it ignore the .prettierrc.json, I'll rollback the last (unnecessarily huge) commit and look into it

prettier should never be a dependency. It's only relevant for development, not for a production build.

@pascalwengerter
Copy link
Contributor Author

pascalwengerter commented Oct 12, 2021 •
edited

Linter is not happy anymore. cry

Seems like adding the direct dependency to prettier somehow makes it ignore the .prettierrc.json, I'll rollback the last (unnecessarily huge) commit and look into it

prettier should never be a dependency. It's only relevant for development, not for a production build.

*devDependency, sure. Somehow there were still a bunch of changes when running yarn lint --fix that actually helped syntax highlighting so I've commited them...ready for review from my POV

@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait2 https://drone.owncloud.com/owncloud/web/19570/43/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19573/12/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter pascalwengerter mentioned this pull request Oct 12, 2021
Merged
5 tasks
kulmann
kulmann requested changes Oct 13, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, please fix the two code smells reported by sonarcloud regarding usages of deprecated atob and btoa.

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability D 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

22.7% 22.7% Coverage
1.0% 1.0% Duplication

@pascalwengerter pascalwengerter merged commit 934bb96 into master Oct 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the chore/clarify-dependencies branch October 13, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pascalwengerter @kulmann @ownclouders