Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pagination on page 2 and following #6056

Merged
merged 1 commit into from Nov 25, 2021
Merged

Fix pagination on page 2 and following #6056

merged 1 commit into from Nov 25, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Nov 24, 2021

Description

Pagination was broken on page 2 and following because the items per page were referenced as strings. firstElementIndex + itemsPerPage for firstElementIndex=0 and itemsPerPage="100" resulted in 0100.

Motivation and Context

Bugfix

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Nov 24, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

fschade
fschade approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖 one small thing, it looks like this is not covered in our tests, can add one?

@fschade fschade merged commit 51056ff into master Nov 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-pagination branch November 25, 2021 12:04
@kulmann
Copy link
Member Author

kulmann commented Nov 25, 2021

LGTM 🤖 one small thing, it looks like this is not covered in our tests, can add one?

I wanted to say yes, but now you already merged it 😆 thanks for merging 😁

@fschade
Copy link
Collaborator

fschade commented Nov 25, 2021

shittt, sorry i thought yes... get it closed and added a test in my table row PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kulmann @fschade