Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign small fixes #6222

Merged
merged 5 commits into from Jan 8, 2022
Merged

Redesign small fixes #6222

merged 5 commits into from Jan 8, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jan 5, 2022

Description

This PR fixes some small issues from the first redesign iteration:

  • topbar stays visible on pages that don't require authentication, but with a reduced set of items
  • margins around and in between browser top edge <-> topbar <-> app container <-> browser bottom edge are now all equal
  • white border artifact on the left of the sidebar nav is fixed
  • scrollbar issues are fixed
  • height issue in app provider is fixed
  • bonus: fixes a console warning about type check failures when passing undefined into OcResourceSize inside ResourceTable

Related Issue

Motivation and Context

Finetune the main layout

How Has This Been Tested?

  • manually in chrome and firefox

Screenshot

Screenshot 2022-01-05 at 22 26 55

Screenshot 2022-01-05 at 22 37 52

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann
Copy link
Member Author

kulmann commented Jan 5, 2022

cc @wkloucek as this fixes #6203 (comment)

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/21601/16/1
The following scenarios passed on retry:

  • webUIMarkdownEditor/markdownFile.feature:29

@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/21601/17/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/21602/56/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/21602/17/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/21610/41/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪 will merge for now and take over the PR

@lookacat lookacat merged commit d6547da into master Jan 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the redesign-small-fixes branch January 8, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants