Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback link customization #6761

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Feedback link customization #6761

merged 1 commit into from
Apr 8, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Apr 7, 2022

Description

Adds configuration options for overwriting feedback link props

Related Issue

How Has This Been Tested?

  • unit tests to test the overrides

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Apr 7, 2022
@kulmann kulmann force-pushed the feedback-link-customization branch from b648662 to 1e740bf Compare April 8, 2022 10:51
@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit eb90363 into master Apr 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the feedback-link-customization branch April 8, 2022 12:09
ownclouders pushed a commit that referenced this pull request Apr 8, 2022
@kulmann
commit eb90363
338d447 
Merge: c137325 1e740bf
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Fri Apr 8 14:09:19 2022 +0200

    Merge pull request #6761 from owncloud/feedback-link-customization

    Feedback link customization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@kulmann kulmann

Labels
Early-Adopter:CERN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kulmann @pascalwengerter