Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parent folder links for share roots in upload overlay #6916

Merged
merged 1 commit into from May 10, 2022
Merged

Fix parent folder links for share roots in upload overlay #6916

merged 1 commit into from May 10, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

At some point we should refactor all that router logic because it sits all over the place currently. But let's get it to work well first.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this May 9, 2022
@JammingBen JammingBen marked this pull request as ready for review May 9, 2022 12:23
@ownclouders
Copy link
Contributor

Results for oCISSharingPerm2 https://drone.owncloud.com/owncloud/web/25430/65/1
The following scenarios passed on retry:

  • webUISharingFolderAdvancedPermissionsGroups/shareAdvancePermissionsGroup.feature:54
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L56.png

webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup_feature-L56.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

52.6% 52.6% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 2b69b48 into master May 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-share-root-links-in-upload-overlay branch May 10, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parent folder links in uploads to share roots have Personal as label
3 participants
@JammingBen @ownclouders @kulmann