Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new WebDAV endpoints for uploads when spaces are enabled #6991

Merged
merged 2 commits into from May 23, 2022
Merged

Use new WebDAV endpoints for uploads when spaces are enabled #6991

merged 2 commits into from May 23, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

This is basically another continuation of the sharing jail PR.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this May 17, 2022
@JammingBen JammingBen marked this pull request as ready for review May 17, 2022 11:31
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label May 17, 2022
@owncloud owncloud deleted a comment from update-docs bot May 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

54.1% 54.1% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit b09c6fb into master May 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the upload-space-endpoints branch May 23, 2022 08:40
fschade
fschade approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade fschade approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@JammingBen JammingBen

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uploads still make the call to path based WebDAV endpoints when spaces are enabled
3 participants
@JammingBen @kulmann @fschade