Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering unlimited quota #7044

Merged
merged 1 commit into from May 23, 2022
Merged

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented May 23, 2022

Description

Reintroducing a "Personal storage" label in the user menu after #6923 was merged. Also, the used value for the quota details was broken for 0, as that is somehow NaN instead of 0. Fixed by using 0 as a fallback.

Related Issue

Screenshots

Screenshot 2022-05-23 at 16 29 53

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann force-pushed the fix-render-unrestricted-quota branch from 04d50b6 to c35ad20 Compare May 23, 2022 14:38
@kulmann kulmann self-assigned this May 23, 2022
@kulmann kulmann added this to In progress in Web Support Board via automation May 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter merged commit 651b670 into master May 23, 2022
Web Support Board automation moved this from In progress to Done May 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-render-unrestricted-quota branch May 23, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

show unlimited quota / respect quota.definition: none
2 participants