Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent rename button from getting covered #7061

Merged
merged 3 commits into from May 30, 2022
Merged

Prevent rename button from getting covered #7061

merged 3 commits into from May 30, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented May 25, 2022 •
edited

Description

We've fixed a bug where the rename button next to the file name would get covered if there is not enough space available.

Related Issue

Screenshots

Before:

All files

After:

All files

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this May 25, 2022
@JammingBen JammingBen marked this pull request as ready for review May 25, 2022 12:36
@JammingBen JammingBen force-pushed the rename-button-getting-covered branch from 5c5656e to 5100a55 Compare May 25, 2022 12:43
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen requested a review from kulmann May 30, 2022 08:48
kulmann
kulmann approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kulmann kulmann merged commit 1a38e76 into master May 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the rename-button-getting-covered branch May 30, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename-Icon gets covered if there is not enough space
2 participants
@JammingBen @kulmann