Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Allow additional mimeTypes via preview app config #7131

Merged
merged 2 commits into from Jun 20, 2022
Merged

[full-ci] Allow additional mimeTypes via preview app config #7131

merged 2 commits into from Jun 20, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jun 15, 2022

Description

As a mitigation for supported preview types not being announced by the backend, this PR adds support for adding additional mime types via the config.json.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested a review from ChrisEdS June 15, 2022 10:29
@kulmann kulmann self-assigned this Jun 15, 2022
@kulmann kulmann force-pushed the configurable-preview-mimetypes branch from dd7ac9a to 01debdb Compare June 15, 2022 10:46
@kulmann kulmann mentioned this pull request Jun 15, 2022
Closed
25 tasks
@ownclouders
Copy link
Contributor

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/26259/57/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesActionMenu-fileFolderActionMenu_feature-L14.png

webUIFilesActionMenu-fileFolderActionMenu_feature-L14.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@kulmann kulmann changed the title Allow additional mimeTypes via preview app config [full-ci] Allow additional mimeTypes via preview app config Jun 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 430bd7a into master Jun 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the configurable-preview-mimetypes branch June 20, 2022 08:10
ownclouders pushed a commit that referenced this pull request Jun 20, 2022
@kulmann
commit 430bd7a
648cbdf 
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Mon Jun 20 10:10:25 2022 +0200

    [full-ci] Allow additional mimeTypes via preview app config (#7131)

    Allow additional mimeTypes via preview app config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

@ChrisEdS ChrisEdS Awaiting requested review from ChrisEdS

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

utilize oc10 preview providers for allowed mime types in preview app
3 participants
@kulmann @ownclouders @pascalwengerter