External apps fixes #7166
Closed
External apps fixes #7166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
added
Type:Bug
diocas
force-pushed
the
up/external_apps_fix
branch
from
84b29dd
to
715e980
Compare
diocas
force-pushed
the
up/external_apps_fix
branch
from
715e980
to
bb5a42e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Hey, thank you for this fix! That's actually blocking the ocis beta.4 release because, as you mentioned, wopi server usage in web is completely broken. |
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6870 brought a couple of issues.. One, is that external apps extension is completely broken, because
makeRequestwas moved to a different place and never imported into defaultApps.The second is that the behavior of the method has also changed. (Draw.io is still broken when importing visio files).
The other - not as important - regression is that the app name no longer appears in the title.