Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Search does not find all files #7267

Merged
merged 9 commits into from Jul 20, 2022
Merged

Fix: Search does not find all files #7267

merged 9 commits into from Jul 20, 2022

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 12, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Start implementation Fix: Search does not find all files Jul 13, 2022
@AlexAndBear AlexAndBear mentioned this pull request Jul 13, 2022
Closed
pascalwengerter
pascalwengerter approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! I'd suggest adding the SDK bump changelog update in a subsequent PR

yarn.lock
"owncloud-sdk@npm:~3.0.0-alpha.14":
version: 3.0.0-alpha.14
resolution: "owncloud-sdk@npm:3.0.0-alpha.14"
"owncloud-sdk@npm:~3.0.0-alpha.15":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use a changelog update :)

@AlexAndBear
Copy link
Contributor Author

@fschade still not quite sure if we should change the searchResult(s) Interface, would require some rework

@AlexAndBear @kulmann
Update packages/web-app-files/src/components/Search/List.vue
7c80ca5 
Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
@AlexAndBear AlexAndBear requested a review from kulmann July 20, 2022 13:39
@fschade
Copy link
Collaborator

fschade commented Jul 20, 2022

@kulmann can you take over the interface question from jan, i have too much open things at the moment and not enough time to decide and give a proper answer

@AlexAndBear
Copy link
Contributor Author

decided we will change the interface in a upcoming pr

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

60.0% 60.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 24314e4 into master Jul 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7192 branch July 20, 2022 14:30
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

@lookacat lookacat Awaiting requested review from lookacat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search does not find all files
4 participants
@AlexAndBear @fschade @kulmann @pascalwengerter