Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Skip tests related to issue-ocis-1328 on ocis #7289

Merged
merged 1 commit into from
Jul 19, 2022
Merged

[tests-only][full-ci] Skip tests related to issue-ocis-1328 on ocis #7289

merged 1 commit into from
Jul 19, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Jul 19, 2022 •
edited
Loading

Description

This PR skips tests related to the issue owncloud/ocis#1328 for OCIS as these will be implemented for spaces but not like they are implemented in OC10 now.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@ownclouders
Copy link
Contributor

Results for oC10Sharing1 https://drone.owncloud.com/owncloud/web/26889/24/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIRestrictSharing-disableSharing_feature-L31.png

webUIRestrictSharing-disableSharing_feature-L31.png

webUIRestrictSharing-disableSharing_feature-L47.png

webUIRestrictSharing-disableSharing_feature-L47.png

@SwikritiT SwikritiT force-pushed the skip-sharing-setting-related-tests-ocis branch from c690d38 to 8d1e915 Compare July 19, 2022 08:26
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SwikritiT
SwikritiT commented Jul 19, 2022
View reviewed changes
tests/acceptance/features/webUIMoveFilesFolders/moveFiles.feature
@@ -93,7 +93,7 @@ Feature: move files
And as "Alice" file "simple-folder/simple-empty-folder/data.zip" should exist in the server
But as "Alice" file "simple-folder/data.zip" should not exist in the server

@issue-ocis-1328
@skipOnOCIS
Scenario: move a file into another folder with no change permission
Copy link
Contributor Author

@SwikritiT SwikritiT Jul 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not related to owncloud/ocis#1328, was linked to it in expected to fail. But after share jail the shares reside in a different section. It was probably kept under that issue because it wasn't possible to get share in root in OCIS

SwikritiT
SwikritiT commented Jul 19, 2022
View reviewed changes
tests/acceptance/features/webUIMoveFilesFolders/moveFolders.feature
@@ -68,7 +68,7 @@ Feature: move folders
| "question?" | "target-folder-with-question?" |
| "&and#hash" | "target-folder-with-&and#hash" |

@issue-ocis-1328
@skipOnOCIS
Copy link
Contributor Author

@SwikritiT SwikritiT Jul 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not related to owncloud/ocis#1328, was linked to it in expected to fail. But after share jail the shares reside in a different section. It was probably kept under that issue because it wasn't possible to get share in root in OCIS

@SwikritiT SwikritiT marked this pull request as ready for review July 19, 2022 09:44
@SwikritiT SwikritiT mentioned this pull request Jul 19, 2022
Closed
@SwikritiT SwikritiT self-assigned this Jul 19, 2022
@phil-davis phil-davis merged commit 3efd580 into master Jul 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the skip-sharing-setting-related-tests-ocis branch July 19, 2022 12:04
@SwikritiT SwikritiT mentioned this pull request Jul 20, 2022
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

@saw-jan saw-jan Awaiting requested review from saw-jan

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SwikritiT @ownclouders @phil-davis