Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simplify mime type checking #7605

Merged
merged 2 commits into from Sep 8, 2022
Merged

chore: simplify mime type checking #7605

merged 2 commits into from Sep 8, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 8, 2022 •
edited

Description

This removes the dependency to guzzle.

Supersedes #5933

Motivation and Context

Maintain compatibility with oc10 (change needed for oc10.11 release).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann mentioned this pull request Sep 8, 2022
Closed
11 tasks
@kulmann kulmann self-assigned this Sep 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit c763c03 into master Sep 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the simplify-mime-type-checking branch September 8, 2022 09:36
@micbar micbar mentioned this pull request Sep 12, 2022
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kulmann @JammingBen