Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Optimize share loading part II #7638

Merged
merged 21 commits into from
Sep 19, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Sep 13, 2022

Description

Continuation of #7580

  • Remove loadCurrentFileOutgoingShares and loadIncomingShares mutations. Instead, incoming and outgoing shares are now being loaded via loadSharesTree(). This avoids getShare() requests from being executed multiple times.
  • Decouple shares member loading from shares loading in store. This reduces the fetching of space members to a minimum and improves the structure of the code.
  • Fix reactive loading of share indicators in sidebar details panel.
  • Fix reactive loading of space member count in the spaces overview.
  • Fix loading of indirect shares within spaces.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Sep 13, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Sep 13, 2022

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/28342/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L133.png

webUISharingPublicManagement-shareByPublicLink_feature-L133.png

@JammingBen JammingBen force-pushed the increase-share-loading-performance branch from 86211a6 to 8c29a6f Compare September 13, 2022 09:26
@JammingBen JammingBen changed the title [full-ci] Increase share loading performance [full-ci] Optimize share loading part II Sep 13, 2022
@JammingBen JammingBen force-pushed the increase-share-loading-performance branch from 029fa59 to 3d6a77d Compare September 14, 2022 12:16
@JammingBen JammingBen force-pushed the increase-share-loading-performance branch from 3d6a77d to 093dfb8 Compare September 14, 2022 12:20
Comment on lines +427 to +428
// FIXME: We need the storageId of each parent resource here
const spaceRef = indirect ? null : storageId
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ugly... We can't take the storageId of the current resource for each of its parents. This currently results in incorrect indirect shares being displayed when both of the following applies:

a) You are in in nested folder (at least 2 levels deep)
b) You (re-)load the page within the folder. Navigating from the outside into the folder should be fine.

@owncloud owncloud deleted a comment from update-docs bot Sep 14, 2022
@JammingBen JammingBen marked this pull request as ready for review September 14, 2022 13:28
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 💪 Only some nitpicks about mutation naming, see comments.

packages/web-app-files/src/views/spaces/Project.vue Outdated Show resolved Hide resolved
packages/web-runtime/src/store/spaces.ts Outdated Show resolved Hide resolved
packages/web-runtime/src/store/spaces.ts Outdated Show resolved Hide resolved
packages/web-runtime/src/store/spaces.ts Outdated Show resolved Hide resolved
packages/web-runtime/src/store/spaces.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

20.2% 20.2% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 8914c3f into master Sep 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the increase-share-loading-performance branch September 19, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants