Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mtime header for tus requests #7641

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fix mtime header for tus requests #7641

merged 1 commit into from
Sep 14, 2022

Conversation

JammingBen
Copy link
Collaborator

Description

Turns out, headers such as mtime have to be passed via upload-metadata to tus. See owncloud/ocis#4559 (comment).

I removed the header object from the tus plugin again, as it has no use.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Sep 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review September 14, 2022 12:32
@JammingBen JammingBen merged commit 2f3c960 into master Sep 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-mtime-tus-uploads branch September 14, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JammingBen @AlexAndBear