[full-ci] Refactor copy/move, Bugfix: Inhibit move files between spaces and disable copy/move overwrite on self

[lookacat]

Description

See #6892 (comment)

I also took the time to refactor the existing code.

Related Issue

• Fixes Copy/move only works with personal space #6892

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added

Open tasks:

• @tbsbdr Needs Contextual Helper Mockup/Text (this are all possible variations: https://owncloud.design/#/oC%20Components/OcContextualHelper)
• Enhancement: Give OcModal the option to use OcContextualHelper owncloud-design-system#2325 Needs to be review & merged
• New ODS release

[ownclouders]

Results for oCISWebdavLockProtection https://drone.owncloud.com/owncloud/web/28796/53/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIWebdavLockProtection-move_feature-L59.png

webUIWebdavLockProtection-move_feature-L60.png

[JammingBen]

In general, I'm not too sure about the upload.ts helper. It feels a bit weird to inject so many "things". Also, we already have the useUploadHelpers composable. Maybe that would be a better fit?

Edit: The onFilesSelected could look something like this:

onFilesSelected(files: File[]) {
      const uppyResources: UppyResource[] = this.inputFilesToUppyFiles(files)
      const quotaExceeded = this.checkQuotaExceeded(uppyResources)
      if (quotaExceeded) {
        return this.$uppyService.clearInputs()
      }

      const filesToUpload = this.getFilesToUpload(...)
      if (!filesToUpload.length) {
        return this.$uppyService.clearInputs()
      }

      return this.handleUppyFileUpload(this.space, this.item, filesToUpload)
}

The methods checkQuotaExceeded and getFilesToUpload are in the uploadHelpersComposable. getFilesToUpload just wraps the conflict handling, but only returns the files to be uploaded.

[lookacat]

@JammingBen the idea with the upload.ts was that we have all conflict resolving logic at the same place/same folder. When I refactored this it was all done in CreateAndUpload thats why i tried to extract it. But I can put it in composables if thats the better fit.

[JammingBen]

@JammingBen the idea with the upload.ts was that we have all conflict resolving logic at the same place/same folder. When I refactored this it was all done in CreateAndUpload thats why i tried to extract it. But I can put it in composables if thats the better fit.

Let's keep it that way for now 🙂 In the future we should refactor all that upload-qutoa-conflict-stuff, because it is spread all over the place. But that's something after GA I suppose.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells

54.0% Coverage
0.0% Duplication

[kulmann]

👍