Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Bugfix: Issues related to transfer/upload and keyboard actions #7735

Merged
merged 3 commits into from
Oct 5, 2022
Merged

[full-ci] Bugfix: Issues related to transfer/upload and keyboard actions #7735

merged 3 commits into from
Oct 5, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Oct 4, 2022 •
edited

Description

Small wording and formatting correction in copy/move. Fixed an issue that caused keyboard actions to not work on checkboxes.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 4, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review October 5, 2022 12:06
@lookacat lookacat changed the title Bugfix: Issues related to transfer/upload and keyboard actions [full-ci] Bugfix: Issues related to transfer/upload and keyboard actions Oct 5, 2022
JammingBen
JammingBen reviewed Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, rest LGTM. You could also add the PR link to the existing changelog item.

packages/web-runtime/src/App.vue Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2022 •
edited

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

10.5% 10.5% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit 22eeffc into master Oct 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the transfer-resource-followup branch October 5, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy/move only works with personal space
2 participants
@lookacat @JammingBen