Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logic how passwordProfile is handled #7820

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Change logic how passwordProfile is handled #7820

merged 2 commits into from
Oct 19, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Oct 18, 2022 •
edited

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Oct 18, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

AlexAndBear
AlexAndBear commented Oct 18, 2022
View reviewed changes
packages/web-app-user-management/src/views/Users.vue
@@ -177,7 +177,6 @@ export default defineComponent({

users.value.forEach((user) => {
user.memberOf = user.memberOf || []
user.passwordProfile = user.passwordProfile || { password: '' }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to have it in the user object itself anymore, we don't retrieve those data on a get request and just send it while updating the user

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear marked this pull request as ready for review October 18, 2022 15:20
@AlexAndBear AlexAndBear merged commit 71e172d into master Oct 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7761 branch October 19, 2022 10:51
@AlexAndBear AlexAndBear mentioned this pull request Oct 19, 2022
Closed
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine Edit User view User Management: Reload data after creating a new user
2 participants
@AlexAndBear @JammingBen