Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry failed uploads on re-upload #8055

Merged
merged 2 commits into from Dec 2, 2022
Merged

Retry failed uploads on re-upload #8055

merged 2 commits into from Dec 2, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Dec 1, 2022

Description

When re-uploading a file that failed uploading before (or after closing the browser-tab during the upload), the upload is now being retried instead of being started from scratch again. This fixes some issues with the overlay and preserves the upload progress.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Dec 1, 2022
@JammingBen JammingBen force-pushed the retry-failed-uploads branch 2 times, most recently from fe918e5 to bf28576 Compare December 2, 2022 07:42
@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/30317/73/1
💥 The oC10IntegrationApp1 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp2 https://drone.owncloud.com/owncloud/web/30317/74/1
💥 The oC10IntegrationApp2 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISTrashbinJourney https://drone.owncloud.com/owncloud/web/30317/71/1
💥 The oCISTrashbinJourney tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 3722ebe into master Dec 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the retry-failed-uploads branch December 2, 2022 15:23
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading same empty file multiple times behaves differently
3 participants