Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Skip tests that open shares folder in ocis #8110

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

SwikritiT
Copy link
Contributor

Description

The tests changed by this PR try to open the shares folder using the webui which is not possible in ocis because of the implementation of the shares jail. Thus they're tagged notToImplementOnOCIS

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI
  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@SwikritiT SwikritiT self-assigned this Dec 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@SwikritiT SwikritiT merged commit 768afcb into master Dec 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the refactor-expected-to-fail-for-closed-issue-part-6 branch December 14, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants