Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve admin settings user management graph api usage #8261

Merged
merged 14 commits into from Jan 26, 2023
Merged

Improve admin settings user management graph api usage #8261

merged 14 commits into from Jan 26, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jan 18, 2023 •
edited by kulmann

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jan 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear force-pushed the admin-settings-user-management-roles-graph branch from 3731fd6 to 1ad9a84 Compare January 18, 2023 08:28
@AlexAndBear AlexAndBear force-pushed the admin-settings-user-management-roles-graph branch from 3d2d665 to 664f203 Compare January 25, 2023 15:11
@AlexAndBear AlexAndBear force-pushed the admin-settings-user-management-roles-graph branch from 664f203 to e7a9d0c Compare January 25, 2023 15:34
kulmann
kulmann requested changes Jan 25, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some smaller issues (see comments). "just works", nice! I was a bit confused by the fact that the backend lists multiple app role assignments per user. But that's certainly not a client issue. If there is not ocis issue for that, yet, I'd love to see that you create one.

changelog/unreleased/enhancement-admin-settings-users-role-graph-api-usage Outdated Show resolved Hide resolved
changelog/unreleased/enhancement-admin-settings-users-role-graph-api-usage Outdated Show resolved Hide resolved
packages/web-app-admin-settings/tests/unit/views/Users.spec.ts Show resolved Hide resolved
packages/web-app-admin-settings/src/views/Users.vue Outdated Show resolved Hide resolved
packages/web-app-admin-settings/src/components/Users/UsersList.vue Outdated Show resolved Hide resolved
packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue Outdated Show resolved Hide resolved
packages/web-app-admin-settings/src/components/Users/SideBar/EditPanel.vue Outdated Show resolved Hide resolved
AlexAndBear and others added 2 commits January 25, 2023 20:58
@AlexAndBear @kulmann
Update changelog/unreleased/enhancement-admin-settings-users-role-gra…
1313258 
…ph-api-usage

Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
@AlexAndBear @kulmann
Update changelog/unreleased/enhancement-admin-settings-users-role-gra…
4039a75 
…ph-api-usage

Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
@AlexAndBear
Copy link
Contributor Author

Found some smaller issues (see comments). "just works", nice! I was a bit confused by the fact that the backend lists multiple app role assignments per user. But that's certainly not a client issue. If there is not ocis issue for that, yet, I'd love to see that you create one.

Ummm spoke with Jörn about this. Works as designed let's talk about it tomorrow, tough.

kulmann
kulmann approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

JammingBen
JammingBen approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice 👍

@JammingBen JammingBen marked this pull request as ready for review January 26, 2023 10:37
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

64.0% 64.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 8c18a54 into master Jan 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the admin-settings-user-management-roles-graph branch January 26, 2023 11:57
ownclouders pushed a commit that referenced this pull request Jan 26, 2023
@AlexAndBear
commit 8c18a54
03bc509 
Author: Jan <jackermann@owncloud.com>
Date:   Thu Jan 26 12:57:46 2023 +0100

    Improve admin settings user management graph api usage (#8261)

    * Init

    * Start fixing tests

    * Current state

    * Update changelog/unreleased/enhancement-admin-settings-users-role-graph-api-usage

    Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>

    * Update changelog/unreleased/enhancement-admin-settings-users-role-graph-api-usage

    Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>

    * React on code review

    * Split editUser into functions

    * Don't interpolate user drive due to api improvements

    * Update changelog item

    * Finish line

    * Fix up duplicate code

    * Fix up

    * Remove loadTasks index file

    * Update snapshot

    Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
    Co-authored-by: Jannik Stehle <jannik.stehle@gmail.com>
@JammingBen JammingBen mentioned this pull request Jan 26, 2023
Closed
5 tasks
@kulmann kulmann mentioned this pull request Jan 26, 2023
Closed
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Improve user listing performance
3 participants
@AlexAndBear @kulmann @JammingBen