Provide light and dark logos in common section #8855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clients may use these logos for theming.
fmoc
requested review from
TheOneRing,
michaelstingl,
hosy,
kulmann,
micbar and
abelgardep
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| "slogan": "ownCloud – A safe home for all your data" | ||
| }, | ||
| "logo-dark": { | ||
| "generic": "themes/owncloud/assets/logo_dark.svg" |
There was a problem hiding this comment.
What's the point of having a generic key instead of going for "logo": "URL", "logo-dark": "URL", "logo-light": "URL"?
Also, can I offer my help in finalizing this PR? :)
|
This is stale and outdated by now... I'll close here. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #8787. Required for owncloud/client#10519. Feedback welcome!