Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty file list after deleting resources #9017

Merged
merged 1 commit into from May 31, 2023
Merged

Fix empty file list after deleting resources #9017

merged 1 commit into from May 31, 2023

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented May 11, 2023 •
edited

Description

Fixes an issue where the file list would be empty after deleting all resources on the last page. The file list now resets the pagination in such scenario.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this May 11, 2023
@JammingBen
Copy link
Collaborator Author

JammingBen commented May 11, 2023 •
edited

@kulmann Do you agree with resetting the pagination when deleting resources and the pagination is > 1? It would be nicer to do this only in case all resources on the current page have been removed, but that involves a bit more logic. -> implemented it so that it only applies when all resources on the last page are being deleted.

@JammingBen JammingBen force-pushed the fix-empty-file-list-after-deletion branch 4 times, most recently from ba784d5 to e8c4569 Compare May 31, 2023 08:46
lookacat
lookacat approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@JammingBen
fix: empty file list after deleting all resources on last page
e9b92ab 
Fixes an issue where the file list would be empty after deleting all resources on the last page. The file list now resets the pagination in such scenario.
@JammingBen JammingBen force-pushed the fix-empty-file-list-after-deletion branch from e8c4569 to e9b92ab Compare May 31, 2023 09:24
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

76.9% 76.9% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 6514f01 into stable-7.0 May 31, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-empty-file-list-after-deletion branch May 31, 2023 09:57
@JammingBen JammingBen mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JammingBen @lookacat @kulmann @AlexAndBear